Subject: Re: [take5 1/4] kevent: Core files.

From: Evgeniy Polyakov <[email-masked]>
Date: Wed, 9 Aug 2006 09:22:11 +0400

On Tue, Aug 08, 2006 at 03:02:59PM -0700, Zach Brown ([email-masked]) wrote:
> 
> > +++ b/include/linux/kevent.h
> 
>  ...
> 
> > +#ifdef CONFIG_KEVENT_SOCKET
> > +
> > +extern struct file_operations socket_file_ops;
> 
> This doesn't build because socket_file_ops was left static in net/socket.c.

I exported it. It just sneaked out of patchset.

> In any case, kevent.h has no business exposing socket_file_ops to users
> of the kevent api just so the kevent core can test files as being backed
> by sockets.  It'd be more appropriate to call into the socket layer with
> the filp and let it return -EINVAL or -ESOCKNOOPT instead of trying to
> do that in the kevent layer.

Ok, I will move to use some functions from socket code without exporting
socket_file_ops.

> - z

-- 
	Evgeniy Polyakov