From: Thomas Graf <tgraf@suug•ch>
To: Ville Nuorvala <vnuorval@tcs•hut.fi>
Cc: David Miller <davem@davemloft•net>, netdev@vger•kernel.org
Subject: Re: [PATCH][IPV6]: Make sure fib6_rule_lookup doesn't return NULL
Date: Wed, 9 Aug 2006 11:23:11 +0200 [thread overview]
Message-ID: <20060809092311.GU14627@postel.suug.ch> (raw)
In-Reply-To: <44D99E73.1060305@tcs.hut.fi>
* Ville Nuorvala <vnuorval@tcs•hut.fi> 2006-08-09 11:36
> Of the three original route lookup functions (ip6_route_input,
> ip6_route_output and rt6_lookup), rt6_lookup was the only one that was
> allowed to produce a NULL entry. Of these three rt6_lookup was also the
> only one not actually being used for routing.
>
> The function that absolutely requires ip6_null_entry is ip6_route_input.
It would mean to change the logic of handling route errors like in the
IPv4 path and not handle them in .input/.output. Instead of a dst we'd
return a valid dst or a ERR_PTR() which would force the caller to take
appropriate actions such as updating statistics and sending ICMPs.
> There is also one more issue with ip6_null_entry: previously it has
> always been the result of an unsuccessful route lookup, now it can also
> be the result of a successful application of a FR_ACT_UNREACHABLE policy
> rule. From a networking point of view these two cases should IMO be
> considered equivalent and should therefore trigger the same response.
> This will however not be true if NULL (or an error code) is the result
> of an unsuccessful route lookup.
Both would simply result in a -ENETUNREACHABLE.
next prev parent reply other threads:[~2006-08-09 9:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-08 22:05 [PATCH][IPV6]: Make sure fib6_rule_lookup doesn't return NULL Ville Nuorvala
2006-08-08 22:16 ` Thomas Graf
2006-08-08 23:43 ` David Miller
2006-08-09 6:31 ` Ville Nuorvala
2006-08-09 6:34 ` David Miller
2006-08-09 8:36 ` Ville Nuorvala
2006-08-09 9:23 ` Thomas Graf [this message]
2006-08-09 9:42 ` Ville Nuorvala
2006-08-09 9:48 ` Thomas Graf
2006-08-09 10:45 ` Ville Nuorvala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060809092311.GU14627@postel.suug.ch \
--to=tgraf@suug$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vnuorval@tcs$(echo .)hut.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox