Subject: Re: [PATCH 2.6.17 2/9] NetXen: Hardware access routines

From: "Amit S. Kale" <[email-masked]>
Date: Mon, 21 Aug 2006 13:57:23 +0530

We can certainly create a table for all error messages. It'll hurt readability 
of code in many of the other places where printks are used to indicate some 
hardware error.
-Amit

On Friday 18 August 2006 20:46, Stephen Hemminger wrote:
> > +	if (fw_major != _NETXEN_NIC_LINUX_MAJOR) {
> > +		printk(KERN_ERR "The mismatch in driver version and firmware "
> > +			"version major number\n"
> > +			"Driver version major number = %d \t"
> > +			"Firmware version major number = %d \n",
> > +			_NETXEN_NIC_LINUX_MAJOR, fw_major);
> > +		adapter->driver_mismatch = 1;
> > +	}
> > +	if (fw_minor != _NETXEN_NIC_LINUX_MINOR) {
> > +		printk(KERN_ERR "The mismatch in driver version and firmware "
> > +			"version minor number\n"
> > +			"Driver version minor number = %d \t"
> > +			"Firmware version minor number = %d \n",
> > +			_NETXEN_NIC_LINUX_MINOR, fw_minor);
> > +		adapter->driver_mismatch = 1;
> > +	}
>
> You might want a table for this?