Subject: [PATCH] IPV6 : segmentation offload not set correctly on TCP children

From: Stephen Hemminger <[email-masked]>
Date: Fri, 25 Aug 2006 15:43:53 -0700

TCP over IPV6 would incorrectly inherit the GSO settings.
This would cause kernel to send Tcp Segmentation Offload packets for
IPV6 data to devices that can't handle it. It caused the sky2 driver
to lock http://bugzilla.kernel.org/show_bug.cgi?id=7050
and the e1000 would generate bogus packets. I can't blame the
hardware for gagging if the upper layers feed it garbage.

This was a new bug in 2.6.18 introduced with GSO support.

Signed-off-by: Stephen Hemminger <[email-masked]>

--- linux-2.6.orig/net/ipv6/tcp_ipv6.c	2006-08-03 09:09:16.000000000 -0700
+++ linux-2.6/net/ipv6/tcp_ipv6.c	2006-08-25 15:30:31.000000000 -0700
@@ -944,7 +944,7 @@
 	 * comment in that function for the gory details. -acme
 	 */
 
-	sk->sk_gso_type = SKB_GSO_TCPV6;
+	newsk->sk_gso_type = SKB_GSO_TCPV6;
 	__ip6_dst_store(newsk, dst, NULL);
 
 	newtcp6sk = (struct tcp6_sock *)newsk;