From: Don Fry <brazilnut@us•ibm.com>
To: Alexey Dobriyan <adobriyan@gmail•com>
Cc: netdev@vger•kernel.org, tsbogend@alpha•franken.de
Subject: Re: [PATCH] pcnet32: fix user visible typo
Date: Mon, 28 Aug 2006 16:51:42 -0700 [thread overview]
Message-ID: <20060828235142.GA6633@us.ibm.com> (raw)
In-Reply-To: <20060828233248.GA5193@martell.zuzino.mipt.ru>
The cause of #6428 has already been fixed in v1.32 of the pcnet32
driver. To be correct, the printk should be:
printk(KERN_INFO PFX "%d card%s found\n",
cards_found, cards_found != 1 ? "s" : "");
So that zero cards also says 'pcnet32: 0 cards found.'
Why delete the period from the end of the sentence?
On Tue, Aug 29, 2006 at 03:32:49AM +0400, Alexey Dobriyan wrote:
> Also, final dot removed and single form fixed. The cause of #6428 is
> still to be found.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail•com>
> ---
>
> drivers/net/pcnet32.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> --- a/drivers/net/pcnet32.c
> +++ b/drivers/net/pcnet32.c
> @@ -2986,7 +2986,8 @@ static int __init pcnet32_init_module(vo
> pcnet32_probe_vlbus(pcnet32_portlist);
>
> if (cards_found && (pcnet32_debug & NETIF_MSG_PROBE))
> - printk(KERN_INFO PFX "%d cards_found.\n", cards_found);
> + printk(KERN_INFO PFX "%d card%s found\n",
> + cards_found, cards_found > 1 ? "s" : "");
>
> return (pcnet32_have_pci + cards_found) ? 0 : -ENODEV;
> }
>
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger•kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Don Fry
brazilnut@us•ibm.com
next prev parent reply other threads:[~2006-08-28 23:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-28 23:32 [PATCH] pcnet32: fix user visible typo Alexey Dobriyan
2006-08-28 23:51 ` Don Fry [this message]
2006-08-29 15:37 ` Don Fry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060828235142.GA6633@us.ibm.com \
--to=brazilnut@us$(echo .)ibm.com \
--cc=adobriyan@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=tsbogend@alpha$(echo .)franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox