Subject: Re: [PATCH 3/5] skge: use dev_alloc_skb

From: Christoph Hellwig <[email-masked]>
Date: Tue, 29 Aug 2006 12:23:36 +0100

On Mon, Aug 28, 2006 at 04:19:37PM -0700, Stephen Hemminger wrote:
> To avoid problems with buggy protocols that assume extra header space,
> use dev_alloc_skb() when allocating receive buffers.
> 
> Signed-off-by: Stephen Hemminger <[email-masked]>
> 
> --- skge-2.6.orig/drivers/net/skge.c
> +++ skge-2.6/drivers/net/skge.c
> @@ -827,7 +827,8 @@ static int skge_rx_fill(struct skge_port
>  	do {
>  		struct sk_buff *skb;
>  
> -		skb = alloc_skb(skge->rx_buf_size + NET_IP_ALIGN, GFP_KERNEL);
> +		skb = __dev_alloc_skb(skge->rx_buf_size + NET_IP_ALIGN,
> +				      GFP_KERNEL);

While you're at it please use netdev_alloc_skb.