Subject: Re: [PATCH] pcnet32: fix user visible typo

From: Don Fry <[email-masked]>
Date: Tue, 29 Aug 2006 08:37:44 -0700

Alexey,

Your patch is fine.  I had not looked at the if which would prevent zero
cards from even printing.

On Mon, Aug 28, 2006 at 04:51:42PM -0700, Don Fry wrote:
> The cause of #6428 has already been fixed in v1.32 of the pcnet32
> driver.  To be correct, the printk should be:
> 
> 		printk(KERN_INFO PFX "%d card%s found\n",
> 			cards_found, cards_found != 1 ? "s" : "");
> 
> So that zero cards also says 'pcnet32: 0 cards found.'
> Why delete the period from the end of the sentence?
> 
> On Tue, Aug 29, 2006 at 03:32:49AM +0400, Alexey Dobriyan wrote:
> > Also, final dot removed and single form fixed. The cause of #6428 is
> > still to be found.
> > 
> > Signed-off-by: Alexey Dobriyan <[email-masked]>
> > ---
> > 
> >  drivers/net/pcnet32.c |    3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > --- a/drivers/net/pcnet32.c
> > +++ b/drivers/net/pcnet32.c
> > @@ -2986,7 +2986,8 @@ static int __init pcnet32_init_module(vo
> >  		pcnet32_probe_vlbus(pcnet32_portlist);
> >  
> >  	if (cards_found && (pcnet32_debug & NETIF_MSG_PROBE))
> > -		printk(KERN_INFO PFX "%d cards_found.\n", cards_found);
> > +		printk(KERN_INFO PFX "%d card%s found\n",
> > +			cards_found, cards_found > 1 ? "s" : "");
> >  
> >  	return (pcnet32_have_pci + cards_found) ? 0 : -ENODEV;
> >  }
> > 
> > -
-- 
Don Fry
[email-masked]