Subject: Re: [BUG] in skge.c on 2.6.18-rc5

From: Stephen Hemminger <[email-masked]>
Date: Wed, 30 Aug 2006 09:17:14 -0700

On Wed, 30 Aug 2006 17:30:46 +0200
"Thibaut VARENE" <[email-masked]> wrote:

> Hi,
> 
> The following commit:
> 
> commit 239e44e1f05e2163ee066c07a753f9fb445979b2
> Author: Edgar E. Iglesias <[email-masked]>
> Date:   Mon Aug 14 23:00:24 2006 -0700
> 
>     [PATCH] skge: remember to run netif_poll_disable()
> 
>     Signed-off-by: Edgar E. Iglesias <[email-masked]>
>     Cc: Stephen Hemminger <[email-masked]>
>     Cc: Jeff Garzik <[email-masked]>
>     Signed-off-by: Andrew Morton <[email-masked]>
>     Signed-off-by: Jeff Garzik <[email-masked]>
> 
> diff --git a/drivers/net/skge.c b/drivers/net/skge.c
> index 7de9a07..ad878df 100644
> --- a/drivers/net/skge.c
> +++ b/drivers/net/skge.c
> @@ -2211,6 +2211,7 @@ static int skge_up(struct net_device *de
>         skge_write8(hw, Q_ADDR(rxqaddr[port], Q_CSR), CSR_START |
> CSR_IRQ_CL_F);        skge_led(skge, LED_MODE_ON);
> 
> +       netif_poll_enable(dev);
>         return 0;
> 
>   free_rx_ring:
> @@ -2279,6 +2280,7 @@ static int skge_down(struct net_device *
> 
>         skge_led(skge, LED_MODE_OFF);
> 
> +       netif_poll_disable(dev);
>         skge_tx_clean(skge);
>         skge_rx_clean(skge);
> 
> 
> panics my 2.6.18-rc5 kernel on my em64t box apparently on first
> network activity (eg 'ping'). Reverting it gets me back to a
> functional kernel

How are you bringing the network up, are you using autonegotiation?

-- 
Stephen Hemminger <[email-masked]>