Subject: Re: [PATCH] bcm43xx-softmac: Init, shutdown and restart fixes

From: "John W. Linville" <[email-masked]>
Date: Mon, 11 Sep 2006 14:29:02 -0400

On Mon, Aug 21, 2006 at 04:52:58PM +0200, Michael Buesch wrote:
> On Monday 21 August 2006 16:43, Larry Finger wrote:

> > @@ -3537,11 +3536,10 @@ static int bcm43xx_init_board(struct bcm
> >         err = bcm43xx_select_wireless_core(bcm, -1);
> >         if (err)
> >                 goto err_crystal_off;
> > -
> > -       bcm43xx_periodic_tasks_setup(bcm);
> >         err = bcm43xx_sysfs_register(bcm);
> >         if (err)
> >                 goto err_wlshutdown;
> > +       bcm43xx_periodic_tasks_setup(bcm);
> >         err = bcm43xx_rng_init(bcm);
> >         if (err)
> >                 goto err_sysfs_unreg;
> 
> Either move bcm43xx_periodic_tasks_setup after rng_init, or
> delete the periodic work again, if rng_init fails.

Larry, will you be posting another patch to account for these comments?

John
-- 
John W. Linville
[email-masked]