From: "John W. Linville" <linville-2XuSBdqkA4R54TAoqtyWWQ@public•gmane.org>
To: Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public•gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
Stefano Brivio <st3-sGOZH3hwPm2sTnJN9+BGXg@public•gmane.org>,
Michael Buesch <mb-fseUSCV1ubazQB+pC5nmwQ@public•gmane.org>,
Broadcom Linux
<bcm43xx-dev-0fE9KPoRgkgATYTw5x5z8w@public•gmane.org>
Subject: Re: [PATCH] fix for system lockups in 2.6.18-rcX caused by bcm43xx
Date: Mon, 11 Sep 2006 15:28:52 -0400 [thread overview]
Message-ID: <20060911192846.GB19326@tuxdriver.com> (raw)
In-Reply-To: <4502E62B.5060601-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
On Sat, Sep 09, 2006 at 11:04:59AM -0500, Larry Finger wrote:
> John W. Linville wrote:
> >On Fri, Sep 08, 2006 at 08:47:54PM -0500, Larry Finger wrote:
> >
> >>PLease send this upstream for inclusion in 2.6.18, if possible. This
> >>patch will not work for
> >>wireless-2.6. That patch will be sent to you soon.
> >
> >Are you saying this will break the upstream branch of wireless-2.6?
> >I'm not too excited about that. Under the normal process, that would
> >mean 2.6.19 would be broken until we get the next patch.
> >
> >When will the patch for the upstream branch be available? Can you make
> >that patch based on this one (i.e. apply this one before generating
> >the next patch)?
>
> It will not break wireless-2.6. I sent the equivalent of this patch for
> wireless-2.6 to you under the subject "[PATCH] bcm43xx-softmac: Init,
> shutdown and restart fixes" on August 21, just after I took over
> maintenance of bcm43xx-softmac. If this is not currently queued, please let
> me know.
OK, I see now. The patch won't apply to the upstream branch at all
due to the open-coded locking patch applied previously.
The problem now is that if I send this up for 2.6.18 then it creates
some messiness in the git repositories. Plus, it still might not
make 2.6.18 because it is already very late.
I think I will have to ask you to hold-on to this until Linus
officially releases 2.6.18. Then you can/should send this patch to
the stable team (stable-u79uwXL29TY76Z2rM5mHXA@public•gmane.org) for inclusion in 2.6.18.1
or later.
> I would like to get a listing of patches for bcm43xx-softmac that are
> queued but not yet applied, and the order in which they will be applied. I
> want to make sure nothing has fallen through the cracks, and that the
> patches will apply cleanly.
I have these:
Date Title
---- -----
8/21 bcm43xx-softmac: Init, shutdown and restart fixes
8/30 WE-21 for bcm43xx
9/3 remove dead code from bcm43xx-softmac
9/4 add firmware version printout
9/6 ucode debug status via sysfs
9/7 remove dead code in bcm43xx_sysfs.c
The first has not been merged because I haven't seen a reply to
Michael's last comments in that thread. The WE-21 patch has not been
merged because I haven't merged the WE-21 stuff yet. The others are
all from last week, which I just haven't processed yet.
Will you be responding to Michael's comments on the "Init, shutdown
and restart fixes" patch?
Thanks,
John
P.S. For some reason, I often have trouble applying your patches.
I'm not sure what process you are using to generate your patches, but
please make sure that your patches can be successfully applied when
your email is fed to 'git applymbox'. If you use git, the output of
'git format-patch' should be usable.
Also, if you could just use "---" instead of a long line of "======",
I think I would have to do less manual processing...thanks!
--
John W. Linville
linville-2XuSBdqkA4R54TAoqtyWWQ@public•gmane.org
next prev parent reply other threads:[~2006-09-11 19:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-09 1:47 [PATCH] fix for system lockups in 2.6.18-rcX caused by bcm43xx Larry Finger
[not found] ` <45021D4A.6040805-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2006-09-09 15:23 ` John W. Linville
2006-09-09 16:04 ` Larry Finger
[not found] ` <4502E62B.5060601-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2006-09-09 19:42 ` Daniel Drake
2006-09-11 19:28 ` John W. Linville [this message]
2006-09-11 19:59 ` Larry Finger
[not found] ` <4505C005.2070302-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2006-09-11 20:35 ` John W. Linville
2006-09-11 22:04 ` Jeff Garzik
2006-09-14 8:25 ` Jarek Poplawski
2006-09-14 8:29 ` Jarek Poplawski
2006-10-05 20:52 ` Randy Dunlap
2006-10-06 5:57 ` Jarek Poplawski
2006-10-06 6:19 ` Jarek Poplawski
2006-10-06 6:57 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060911192846.GB19326@tuxdriver.com \
--to=linville-2xusbdqka4r54taoqtywwq@public$(echo .)gmane.org \
--cc=Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public$(echo .)gmane.org \
--cc=bcm43xx-dev-0fE9KPoRgkgATYTw5x5z8w@public$(echo .)gmane.org \
--cc=mb-fseUSCV1ubazQB+pC5nmwQ@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=st3-sGOZH3hwPm2sTnJN9+BGXg@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox