From: Ismail Donmez <ismail@pardus•org.tr>
To: Jarek Poplawski <jarkao2@o2•pl>, "David S. Miller" <davem@davemloft•net>
Cc: axboe@suse•de, Herbert Xu <herbert@gondor•apana.org.au>,
netdev@vger•kernel.org
Subject: Re: [PATCH] Revert [NET_SCHED]: HTB: fix incorrect use of RB_EMPTY_NODE
Date: Mon, 2 Oct 2006 16:49:38 +0300 [thread overview]
Message-ID: <200610021649.39580.ismail@pardus.org.tr> (raw)
In-Reply-To: <20061002102447.GA2936@ff.dom.local>
02 Eki 2006 Pts 13:24 tarihinde, Jarek Poplawski şunları yazmıştı:
> On 30-09-2006 21:23, Ismail Donmez wrote:
> > Hi,
> >
> > With commit 10fd48f2376db52f08bf0420d2c4f580e39269e1 [1] , RB_EMPTY_NODE
> > changed behaviour so it returns false when the node is empty as expected.
>
> ...
>
> > - if (!RB_EMPTY_NODE(rb)) {
> > + if (RB_EMPTY_NODE(rb)) {
>
> Maybe you have some kind of agreement with Jens Axboe but I
> can't understand current way of kernel cooperation:
> he changes some global behavior to the opposite and fixes
> his code in three places but can't fix it in the fourth place
> where it's used? Isn't it both trivial and automatic kind
> of patch?
I don't know if Jens will going to fix other occurrences but the sch_htb.c fix
was recent and Jens' commit got my attention hence the patch.
Regards,
ismail
next prev parent reply other threads:[~2006-10-02 13:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-30 19:23 [PATCH] Revert [NET_SCHED]: HTB: fix incorrect use of RB_EMPTY_NODE Ismail Donmez
2006-09-30 19:25 ` Ismail Donmez
2006-10-01 1:52 ` Herbert Xu
2006-10-01 6:14 ` Ismail Donmez
2006-10-01 6:17 ` Ismail Donmez
2006-10-02 10:24 ` Jarek Poplawski
2006-10-02 11:15 ` Jarek Poplawski
2006-10-02 11:52 ` Jarek Poplawski
2006-10-03 10:28 ` Jens Axboe
2006-10-03 11:53 ` Jarek Poplawski
2006-10-03 12:54 ` Ismail Donmez
2006-10-03 18:05 ` Patrick McHardy
2006-10-03 20:49 ` David Miller
2006-10-02 13:49 ` Ismail Donmez [this message]
2006-10-03 7:27 ` Jarek Poplawski
2006-10-03 10:30 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200610021649.39580.ismail@pardus.org.tr \
--to=ismail@pardus$(echo .)org.tr \
--cc=axboe@suse$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=jarkao2@o2$(echo .)pl \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox