Subject: Re: [patch 4/6] 2.6.18: sb1250-mac: The actual driver update

From: Ralf Baechle <[email-masked]>
Date: Wed, 4 Oct 2006 02:10:46 +0100

On Tue, Oct 03, 2006 at 04:42:53PM -0700, Andrew Morton wrote:

> On Tue, 3 Oct 2006 16:18:44 +0100 (BST)
> "Maciej W. Rozycki" <[email-masked]> wrote:
> 
> > +	sbmac_state_t		sbm_state;	/* current state */
> 
> argh.
> 
> The reader looks at this and doesn't know if it's an integer, a void*, a
> struct usb_ac_header_descriptor** or what.
> 
> 	enum sbmac_state	smb_state;
> 
> is nicer.  It has information.

De-typedef-ing would be a separate project for this driver which makes
quite generous use of typedefs.

  Ralf