Subject: Re: [patch] Performance enhancement patches for SB1250 MAC

From: Stephen Hemminger <[email-masked]>
Date: Thu, 12 Oct 2006 15:13:56 -0700

On Thu, 12 Oct 2006 14:54:33 -0700
"Yang, Steve" <[email-masked]> wrote:

> FYI ...
> 
> Regards, 
> Steve Yang
> 
> -----Original Message-----
> From: Yang, Steve 
> Sent: Monday, September 25, 2006 3:50 PM
> To: [email-masked]'
> Cc: [email-masked]'; 'Mark E Mason'
> Subject: Performance enhancement patches for SB1250 MAC
> 
> Hi,
> 
> The attached are two network performance enhancement patches for SB1250
> MAC. The NAPI patch applies first. Followed by the "skb cache" patch.
> They applied and builds cleanly on 2.6.18 kernel for the following
> kernel option combinations:
> 
> SBMAC_NAPI	no	yes	yes
> SKB_CACHE	no	no	yes
>  
> Regards,
> Steve Yang
> 

NAK on the SKB_CACHE it is idea that just ends up favoring your
driver at the expense of the rest of the system. Also, there are
resource/memory starvation issues and probably other races as well.

I bet it makes your benchmark run faster, but it doesn't belong in
normal kernel

-- 
Stephen Hemminger <[email-masked]>