Subject: Re: [PATCH 01/02 V3] net/ipv6: seperate sit driver to extra module

From: Joerg Roedel <[email-masked]>
Date: Fri, 13 Oct 2006 21:17:45 +0200

On Fri, Oct 13, 2006 at 08:12:06PM +0200, Jan Dittmer wrote:
> This is missing the MODULE_LICENSE statements and taints the kernel upon
> loading. License is obvious from the beginning of the file.

Ah, ok. I forgot that. Thanks for the fix.

> Joerg Roedel wrote:
> > --- linux-2.6.18-vanilla/net/ipv6/sit.c	2006-09-20 05:42:06.000000000 +0200
> > +++ linux-2.6.18/net/ipv6/sit.c	2006-10-05 16:55:02.000000000 +0200
> > @@ -850,3 +850,6 @@ int __init sit_init(void)
> >  	inet_del_protocol(&sit_protocol, IPPROTO_IPV6);
> >  	goto out;
> >  }
> > +
> > +module_init(sit_init);
> > +module_exit(sit_cleanup);
> 
> Signed-off-by: Jan Dittmer <[email-masked]>
Signed-off-by: Joerg Roedel <[email-masked]>

> 
> --- linux-2.6-amd64/net/ipv6/sit.c~	2006-10-13 17:39:45.000000000 +0200
> +++ linux-2.6-amd64/net/ipv6/sit.c	2006-10-13 17:39:49.000000000 +0200
> @@ -853,3 +853,4 @@ int __init sit_init(void)
> 
>  module_init(sit_init);
>  module_exit(sit_cleanup);
> +MODULE_LICENSE("GPL");