Subject: Re: [patch 1/5] d80211: remove bitfields from ieee80211_tx_control

From: David Kimdon <[email-masked]>
Date: Tue, 17 Oct 2006 10:19:51 -0700

On Mon, Oct 16, 2006 at 06:07:25PM +0200, Michael Buesch wrote:
> On Friday 13 October 2006 21:20, David Kimdon wrote:
> > All one-bit bitfields have been subsumed into the new 'flags'
> > structure member and the new IEEE80211_TXCTL_* definitions.  The
> > multiple bit members were converted to u8, s8 or u16 as appropriate.

I'll answer based on take1, which I just sent to the list.

> 
> And, eh, did this increase or decrease the struct size?

structure sizes did not change.

> Does this generate better or worse code?

It generates slightly smaller code with gcc 4.1.2.

-David