Subject: Re: [PATCH 4/6] net: use bitrev8

From: Akinobu Mita <[email-masked]>
Date: Fri, 20 Oct 2006 11:50:45 +0900

On Thu, Oct 19, 2006 at 01:39:51PM -0700, Andrew Morton wrote:

> A bunch of drivers.
> 
> > ===================================================================
> > --- work-fault-inject.orig/drivers/net/Kconfig
> > +++ work-fault-inject/drivers/net/Kconfig
> > @@ -2500,6 +2500,7 @@ config DEFXX
> >  config SKFP
> >  	tristate "SysKonnect FDDI PCI support"
> >  	depends on FDDI && PCI
> > +	select BITREVERSE
> >  	---help---
> >  	  Say Y here if you have a SysKonnect FDDI PCI adapter.
> >  	  The following adapters are supported by this driver:
> 
> But only one of them selects the library.

Other drivers already select CRC32 and CRC32 selects BITREVERSE.

> But select is problematic and I do wonder whether it'd be simpler to just
> link the thing into vmlinux.

OK. I'll try.