Subject: Re: revert mv643xx change from ubuntu tree

From: Olaf Hering <[email-masked]>
Date: Fri, 20 Oct 2006 07:38:56 +0200

On Fri, Oct 20, Ben Collins wrote:

> On Thu, 2006-10-19 at 14:18 +0200, Olaf Hering wrote:
> > Somehow the Ubuntu guys managed to sneak this compile error into the
> > tree:
> > 
> > commit ce9e3d9953c8cb67001719b5516da2928e956be4
> > 
> >       [mv643xx] Add pci device table for auto module loading.
> > 
> > drivers/net/mv643xx_eth.c:1560: error: array type has incomplete element type
> > drivers/net/mv643xx_eth.c:1561: warning: implicit declaration of function ‘PCI_DEVICE’
> > drivers/net/mv643xx_eth.c:1561: error: ‘PCI_VENDOR_ID_MARVELL’ undeclared here (not in a function)
> > drivers/net/mv643xx_eth.c:1561: error: ‘PCI_DEVICE_ID_MARVELL_MV64360’ undeclared here (not in a function)
> 
> Correct, I missed the include for linux/pci.h.
> 
> This patch has been trailing our tree since 2.6.12. Could you help me to
> understand what in this driver will cause it to be autoloaded by udev
> when compiled as a module?

See commit ce9e3d9953c8cb67001719b5516da2928e956be4, platform devices
have now a modalias entry in sysfs. The network card is not a PCI
device.