From: Stephen Hemminger <shemminger@osdl•org>
To: David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org
Subject: [PATCH 2.4] bridge netfilter deadlock
Date: Wed, 1 Nov 2006 11:45:50 -0800 [thread overview]
Message-ID: <20061101114550.459eead0@localhost.localdomain> (raw)
A deadlock was found in bridge netfilter code (2.4 only), when a device is removed.
The device removal path causes a BPDU to be generated and ends up
self deadlocking on the BR lock.
Simple fix would be to avoid generating config bpdu's
immediately when becoming root bridge, and just let the first hello
timer tick do that.
Signed-off-by: Stephen Hemminger <shemminger@osdl•org>
--- linux-2.4.33.3.orig/net/bridge/br_stp.c 2006-10-30 12:46:59.000000000 -0800
+++ linux-2.4.33.3/net/bridge/br_stp.c 2006-10-30 12:53:59.000000000 -0800
@@ -140,8 +140,8 @@
br->forward_delay = br->bridge_forward_delay;
br_topology_change_detection(br);
br_timer_clear(&br->tcn_timer);
- br_config_bpdu_generation(br);
- br_timer_set(&br->hello_timer, jiffies);
+
+ br_timer_set(&br->hello_timer, jiffies - br->hello_time);
}
/* called under bridge lock */
--
Stephen Hemminger <shemminger@osdl•org>
next reply other threads:[~2006-11-01 19:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-01 19:45 Stephen Hemminger [this message]
2006-11-02 1:29 ` [PATCH 2.4] bridge netfilter deadlock David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061101114550.459eead0@localhost.localdomain \
--to=shemminger@osdl$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox