Subject: Re: [PATCH 1/3] NetXen: Fixed /sys mapping between device and driver

From: Ingo Oeser <[email-masked]>
Date: Tue, 7 Nov 2006 17:49:10 +0100

Hi Amit,

one minor nitpick:

You wrote:
> diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c
> index b54ea16..4effb87 100644
> --- a/drivers/net/netxen/netxen_nic_main.c
> +++ b/drivers/net/netxen/netxen_nic_main.c
[...]
> @@ -1040,7 +1041,7 @@ static int netxen_nic_poll(struct net_de
>   		netxen_nic_enable_int(adapter);
>   	}
> 
> -	return (done ? 0 : 1);
> +	return (!done);
	return !done;

Please lose the braces here (CodingStyle).

Just respin or send this change along with later patchsets.

Regards

Ingo Oeser