Subject: Re: [PATCH] Spidernet - remove ETH_ZLEN check in earlier patch

From: Stephen Hemminger <[email-masked]>
Date: Fri, 10 Nov 2006 09:58:02 -0800

On Fri, 10 Nov 2006 11:50:46 -0600
Jim Lewis <[email-masked]> wrote:

> Subject: Spidernet - remove ETH_ZLEN check in earlier patch
> From: James K Lewis <[email-masked]>
> 
> In an earlier patch, code was added to pad packets that were less that
> ETH_ZLEN (60) bytes using the skb_pad function. This has caused hangs
> when accessing certain NFS mounted file systems. This patch removes the
> check and solves the NFS problem. The driver, with this patch, has been
> tested extensively. Please apply.
> 
> 
> Signed-off-by: James K Lewis <[email-masked]>

Does the hardware do padding for you? The padding is important for the Ethernet
spec, and for security reasons (random memory leakage).

-- 
Stephen Hemminger <[email-masked]>