From: Stephen Hemminger <shemminger@osdl•org>
To: Francois Romieu <romieu@fr•zoreil.com>
Cc: Dale Farnsworth <dale@farnsworth•org>, netdev@vger•kernel.org
Subject: Re: [RFT] mv643xxx_eth_start_xmit oops
Date: Fri, 10 Nov 2006 13:07:15 -0800 [thread overview]
Message-ID: <20061110130715.5e99ce9f@freekitty> (raw)
In-Reply-To: <20061110210343.GA9453@electric-eye.fr.zoreil.com>
On Fri, 10 Nov 2006 22:03:43 +0100
Francois Romieu <romieu@fr•zoreil.com> wrote:
> Dale Farnsworth <dale@farnsworth•org> :
> [...]
> > Can you provide more detail about the leak?
>
> + if (has_tiny_unaligned_frags(skb) && __skb_linearize(skb)) {
> + stats->tx_dropped++;
> + if (net_ratelimit())
> + printk(KERN_DEBUG "%s: failed to linearize tiny "
> + "unaligned fragment\n", dev->name);
> + return NETDEV_TX_OK;
>
> Missing kfree_skb(skb) before returning NETDEV_TX_OK ?
>
skb_linearize is documented to free skb on failure.
--
Stephen Hemminger <shemminger@osdl•org>
next prev parent reply other threads:[~2006-11-10 21:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20061110191745.GA13783@codepoet.org>
2006-11-10 19:54 ` [RFT] mv643xxx_eth_start_xmit oops Stephen Hemminger
2006-11-10 20:30 ` Francois Romieu
2006-11-10 20:53 ` Dale Farnsworth
2006-11-10 21:03 ` Francois Romieu
2006-11-10 21:07 ` Stephen Hemminger [this message]
2006-11-10 21:30 ` Francois Romieu
2006-11-10 21:35 ` Stephen Hemminger
2006-11-10 22:03 ` [NET] Update documentation of skb_linearize Francois Romieu
2006-11-10 22:53 ` David Miller
2006-11-10 23:34 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061110130715.5e99ce9f@freekitty \
--to=shemminger@osdl$(echo .)org \
--cc=dale@farnsworth$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=romieu@fr$(echo .)zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox