From: Stephen Hemminger <shemminger@osdl•org>
To: sanjeev@netxen•com
Cc: "Linsys Contractor Amit S. Kale" <amitkale@netxen•com>,
netdev <netdev@vger•kernel.org>, brazilnut <brazilnut@us•ibm.com>,
jeff@garzik•org, netxenproj@linsyssoft•com, rob@netxen•com,
wendyx <wendyx@us•ibm.com>
Subject: Re: [PATCH 3/3] NetXen: 64-bit memory fixes, driver cleanup
Date: Mon, 20 Nov 2006 10:45:53 -0800 [thread overview]
Message-ID: <20061120104553.434b6ec5@freekitty> (raw)
In-Reply-To: <1163845689.4822.6.camel@nbsanjeev>
On Sat, 18 Nov 2006 15:58:09 +0530
Sanjeev Jorapur <sanjeev@netxen•com> wrote:
> On Fri, 2006-11-17 at 08:40 -0800, Stephen Hemminger wrote:
> > On Fri, 17 Nov 2006 07:36:03 -0800
> > "Linsys Contractor Amit S. Kale" <amitkale@netxen•com> wrote:
> >
> > > NetXen: 1G/10G Ethernet Driver updates
> > > - These fixes take care of driver on machines with >4G memory
> > > - Driver cleanup
> > >
> > > Signed-off-by: Amit S. Kale <amitkale@netxen•com>
> > >
> > > netxen_nic.h | 41 ++++++----
> > > netxen_nic_ethtool.c | 19 ++--
> > > netxen_nic_hw.c | 10 +-
> > > netxen_nic_hw.h | 4
> > > netxen_nic_init.c | 51 +++++++++++-
> > > netxen_nic_isr.c | 3
> > > netxen_nic_main.c | 204 +++++++++++++++++++++++++++++++++++++++++++++++---
> > > netxen_nic_phan_reg.h | 10 +-
> > > 8 files changed, 293 insertions(+), 49 deletions(-)
> > >
> >
> >
> > If you can't DMA from high memory, then don't set NETIF_F_HIGHDMA, why do
> > you need explicit bounce buffers. If you can't DMA from unaligned address,
> > the write a small routine to copy the skb to a new one.
>
>
> The hardware supports DMA into 35 bit addresses. The intent is to
> enable DMA into addresses upto 32G.
>
You should then set the same value for pci_set_dma_mask, because then the IOMMU
can help. See both b44 or tg3 drivers, they have to deal with odd size masks.
I don't think you have to do all the bounce buffer work in the driver.
--
Stephen Hemminger <shemminger@osdl•org>
next prev parent reply other threads:[~2006-11-20 18:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-17 15:36 [PATCH 3/3] NetXen: 64-bit memory fixes, driver cleanup Linsys Contractor Amit S. Kale
2006-11-17 16:40 ` Stephen Hemminger
2006-11-18 10:28 ` Sanjeev Jorapur
2006-11-20 18:45 ` Stephen Hemminger [this message]
2006-11-23 16:32 ` Sanjeev Jorapur
2006-11-27 18:23 ` Stephen Hemminger
-- strict thread matches above, loose matches on Subject: below --
2006-11-28 16:04 Amit S. Kale
2006-11-28 18:40 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061120104553.434b6ec5@freekitty \
--to=shemminger@osdl$(echo .)org \
--cc=amitkale@netxen$(echo .)com \
--cc=brazilnut@us$(echo .)ibm.com \
--cc=jeff@garzik$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netxenproj@linsyssoft$(echo .)com \
--cc=rob@netxen$(echo .)com \
--cc=sanjeev@netxen$(echo .)com \
--cc=wendyx@us$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox