From: Ingo Oeser <netdev@axxeo•de>
To: Dan Williams <dcbw@redhat•com>
Cc: David Kimdon <david.kimdon@devicescape•com>,
Larry Finger <Larry.Finger@lwfinger•net>,
netdev@vger•kernel.org
Subject: Re: d80211: RFC: divide by zero when hw->maxssi not set
Date: Mon, 20 Nov 2006 13:45:07 +0100 [thread overview]
Message-ID: <200611201345.08445.netdev@axxeo.de> (raw)
In-Reply-To: <1163980523.2881.33.camel@localhost.localdomain>
Hi there,
Dan Williams schrieb:
> On Fri, 2006-11-17 at 15:51 -0800, David Kimdon wrote:
> > commit 448bf25bc9e3d70a211fdf235426472089371c43 added
> > ieee80211_get_wireless_stats in net/d80211/ieee80211_ioctl.c. At
> > present we get a divide by zero (oops) if the low level driver does
> > not set the new hw->maxssi field. Perhaps:
> >
> > - reject registration of devices which do not set maxssi
> #1 could be too draconian, but has the benefit of making driver writers
> put _something_ there. Either way, it's pretty obvious to anyone that
> the driver is broken for quality reporting. But at least #1 forces the
> issue to making quality somewhat work.
Looks like a perfect cancdidate for -EINVAL and WARN_ON() at registration.
BUG_ON() is also ok, until that stuff is widely deployed.
That's much better than dummy values, because it doesn't make
people think "Hmm, it works somehow, but I don't know why
(and I don't care why)".
Regards
Ingo Oeser
prev parent reply other threads:[~2006-11-20 12:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-17 23:51 d80211: RFC: divide by zero when hw->maxssi not set David Kimdon
2006-11-17 23:59 ` Michael Wu
2006-11-19 23:55 ` Dan Williams
2006-11-20 12:45 ` Ingo Oeser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200611201345.08445.netdev@axxeo.de \
--to=netdev@axxeo$(echo .)de \
--cc=Larry.Finger@lwfinger$(echo .)net \
--cc=david.kimdon@devicescape$(echo .)com \
--cc=dcbw@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox