Subject: Re: [PATCH 2/5] NetXen: temp monitoring, newer firmware support, mm footprint reduction

From: Stephen Hemminger <[email-masked]>
Date: Thu, 30 Nov 2006 19:13:11 -0800

> > @@ -869,7 +937,10 @@ static inline void netxen_nic_disable_in
> >  	/*
> >  	 * ISR_INT_MASK: Can be read from window 0 or 1.
> >  	 */
> > -	writel(0x7ff, (void __iomem *)(adapter->ahw.pci_base + ISR_INT_MASK));
> > +	writel(0x7ff,
> > +	       (void __iomem
> > +		*)(PCI_OFFSET_SECOND_RANGE(adapter, ISR_INT_MASK)));
> > +
> 
> Yuck

If pci_base were correctly typed __iomem the casting would not
be needed.