Subject: Re: [PATCH 2/3] NetXen: 64-bit memory fixes

From: Stephen Hemminger <[email-masked]>
Date: Fri, 1 Dec 2006 10:56:13 -0800

Please don't mix whitespace and other fixes at same time.
Add a cleanup patch at beginning or end of series.

Please don't add other things like the driver name this in with bounce buffer
patch. Why the name change from netxen to netxen_nic?

> +/* Bounce buffer index */
> +struct bounce_index {
> +	/* Index of a buffer */
> +	unsigned buffer_index;
> +	/* Offset inside the buffer */
> +	unsigned buffer_offset;
> +};
> +
> +#define IS_BOUNCE 0xcafebb

Magic number? is this safe? why? there is a Documentation
file for these magic-number.txt.

> diff --git a/drivers/net/netxen/netxen_nic_isr.c b/drivers/net/netxen/netxen_nic_isr.c
> index ae180fe..f6ae9fd 100644
> --- a/drivers/net/netxen/netxen_nic_isr.c
> +++ b/drivers/net/netxen/netxen_nic_isr.c
> @@ -68,8 +68,7 @@ struct net_device_stats *netxen_nic_get_
>  void netxen_indicate_link_status(struct netxen_adapter *adapter, u32 portno,
>  				 u32 link)
>  {
> -	struct netxen_port *pport = adapter->port[portno];
> -	struct net_device *netdev = pport->netdev;
> +	struct net_device *netdev = (adapter->port[portno])->netdev;
>  

Parens unnecessary here.

-- 
Stephen Hemminger <[email-masked]>