From: Thomas Graf <tgraf@suug•ch>
To: jamal <hadi@cyberus•ca>
Cc: David Miller <davem@davemloft•net>, netdev@vger•kernel.org
Subject: Re: [G[PATCH 1/2][ENETLINK] max cmd boundary chec
Date: Fri, 1 Dec 2006 15:40:58 +0100 [thread overview]
Message-ID: <20061201144058.GG8693@postel.suug.ch> (raw)
In-Reply-To: <1164983427.3562.36.camel@localhost>
* jamal <hadi@cyberus•ca> 2006-12-01 09:30
> Shall i assume that the patch showed up fine i.e no crap like mime?
> I still didnt get an echo back, did it make the list?
>
> On Fri, 2006-01-12 at 13:49 +0100, Thomas Graf wrote:
>
> > I can't see why this should be required. genl_register_ops()
> > enforces a unique command id
> > and genl_ops->cmd is u8 so there is no way to register more than
> > 256 commands anyway.
>
> By mistake during the tutorial, i had the id at something like 321.
> It registered fine but then listing the command showed it with a
> different id than what i thought it should be. I think it chops off
> all the bystes other than the LS one - which is not a good error
> check.
> The compiler will whine actually. If you ignore it (perhaps not seeing
> the warning in a mass compile) it registers just fine.
There is no way to fix this in the interface. If you do u8 op = 312
and ignore the compiler warning which states that the value has been
truncated it can't be helped, the interface will see op = 56 and
register it normally. It is logically impossible to have more than 256
entries on the cmd list, the boundry check you're adding is completely
useless.
next prev parent reply other threads:[~2006-12-01 14:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-01 11:30 [G[PATCH 1/2][ENETLINK] max cmd boundary chec jamal
2006-12-01 12:49 ` Thomas Graf
2006-12-01 14:30 ` jamal
2006-12-01 14:40 ` Thomas Graf [this message]
2006-12-01 14:52 ` jamal
2006-12-01 15:16 ` Thomas Graf
2006-12-01 15:54 ` jamal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061201144058.GG8693@postel.suug.ch \
--to=tgraf@suug$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=hadi@cyberus$(echo .)ca \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox