Subject: Re: [PATCH] allow ip_tables.h to be used from userspace

From: Stephen Hemminger <[email-masked]>
Date: Tue, 5 Dec 2006 10:46:22 -0800

On Tue, 05 Dec 2006 19:38:21 +0100
Patrick McHardy <[email-masked]> wrote:

> Stephen Hemminger wrote:
> > The xtables version of ip_tables.h was no longer usable (in sanitized form)
> > by iproute2 and other applications because sparse annotations had crept
> > in.
> > 
> > @@ -194,7 +194,7 @@ struct ipt_replace
> >  	/* Number of counters (must be equal to current number of entries). */
> >  	unsigned int num_counters;
> >  	/* The old entries' counters. */
> > -	struct xt_counters __user *counters;
> > +	struct xt_counters *counters;
> 
> # Eliminate the contents of (and inclusions of) compiler.h
> 
> 
> HDRSED  := sed  -e "s/ inline / __inline__ /g" \
>                 -e "s/[[:space:]]__user[[:space:]]\+/ /g" \
>                 -e "s/(__user[[:space:]]\+/ (/g" \
> 
> I think this regex should be fixed instead to get rid of it
> while sanitizing (Makefile.headersinst).
> 

But ip_tables.h should still put include of compiler.h inside #ifdef __KERNEL__

-- 
Stephen Hemminger <[email-masked]>