Subject: Re: [KJ] [PATCH] he: tiny space savings

From: Adrian Bunk <[email-masked]>
Date: Sun, 17 Dec 2006 19:28:06 +0100

On Sun, Dec 17, 2006 at 03:56:22PM +0300, Alexey Dobriyan wrote:
> From: Andi Drebes <[email-masked]>
> 
>    text    data     bss     dec     hex filename
>   20015     480      28   20523    502b drivers/atm/he.o
>   19997     480      28   20505    5019 drivers/atm/he.o
> 
> Signed-off-by: Andi Drebes <[email-masked]>
> Signed-off-by: Alexey Dobriyan <[email-masked]>
> ---
> 
>  drivers/atm/he.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/atm/he.c
> +++ b/drivers/atm/he.c
> @@ -101,7 +101,7 @@ #endif /* HE_DEBUG */
>  
>  /* version definition */
>  
> -static char *version = "$Id: he.c,v 1.18 2003/05/06 22:57:15 chas Exp $";
> +static const char version[] = "$Id: he.c,v 1.18 2003/05/06 22:57:15 chas Exp $";
>...

Can't we kill this ancient and outdated version string instead?

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed