From: Stephen Hemminger <shemminger@osdl•org>
To: Jeff Garzik <jgarzik@pobox•com>
Cc: netdev@vger•kernel.org
Subject: [patch 1/6] sky2: dual port NAPI problem
Date: Wed, 20 Dec 2006 13:06:33 -0800 [thread overview]
Message-ID: <20061220210922.633505172@osdl.org> (raw)
In-Reply-To: 20061220210632.183204605@osdl.org
[-- Attachment #1: sky2-dual-port-napi.patch --]
[-- Type: text/plain, Size: 754 bytes --]
Shutting down port 0 disables the NAPI poll used by both ports.
The long term fix will be to separate NAPI object from net device
until then just reenable if needed.
Signed-off-by: Stephen Hemminger <shemminger@osdl•org>
--- sky2-2.6.orig/drivers/net/sky2.c 2006-12-18 12:46:59.000000000 -0800
+++ sky2-2.6/drivers/net/sky2.c 2006-12-18 12:47:30.000000000 -0800
@@ -1511,6 +1511,13 @@
imask &= ~portirq_msk[port];
sky2_write32(hw, B0_IMSK, imask);
+ /*
+ * Both ports share the NAPI poll on port 0, so if necessary undo the
+ * the disable that is done in dev_close.
+ */
+ if (sky2->port == 0 && hw->ports > 1)
+ netif_poll_enable(dev);
+
sky2_gmac_reset(hw, port);
/* Stop transmitter */
--
Stephen Hemminger <shemminger@osdl•org>
next prev parent reply other threads:[~2006-12-22 0:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-20 21:06 [patch 0/6] sky2 driver update (v1.11) Stephen Hemminger
2006-12-20 21:06 ` Stephen Hemminger [this message]
2006-12-26 21:36 ` [patch 1/6] sky2: dual port NAPI problem Jeff Garzik
2006-12-20 21:06 ` [patch 2/6] sky2: power management/MSI workaround Stephen Hemminger
2006-12-20 21:06 ` [patch 3/6] sky2: phy power down needs PCI config write enabled Stephen Hemminger
2006-12-20 21:06 ` [patch 4/6] sky2: better power state management Stephen Hemminger
2006-12-26 21:37 ` Jeff Garzik
2006-12-20 21:06 ` [patch 5/6] sky2: add Wake On Lan support Stephen Hemminger
2006-12-20 21:06 ` [patch 6/6] sky2: version 1.11 Stephen Hemminger
2006-12-26 21:44 ` [patch 0/6] sky2 driver update (v1.11) Jeff Garzik
2007-01-01 18:36 ` Stephen Hemminger
2007-01-02 19:10 ` Tino Keitel
2007-01-13 13:03 ` Tino Keitel
2007-01-15 18:21 ` Stephen Hemminger
2007-01-15 19:12 ` Tino Keitel
2007-01-02 21:52 ` Gerd v. Egidy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061220210922.633505172@osdl.org \
--to=shemminger@osdl$(echo .)org \
--cc=jgarzik@pobox$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox