Subject: Re: [PATCH] igmp: spin_lock_bh in timer (Re: BUG: soft lockup detected on CPU#0!)

From: Jarek Poplawski <[email-masked]>
Date: Fri, 22 Dec 2006 13:53:27 +0100

On Fri, Dec 22, 2006 at 10:16:30PM +1100, Herbert Xu wrote:
> Jarek Poplawski <[email-masked]> wrote:
> >
> > [PATCH] igmp: spin_lock_bh in timer
> > 
> > igmp_timer_expire() uses spin_lock(&im->lock)
> > but this lock is also taken by other igmp timers,
> > so it should be changed to bh version.
> 
> When you're in a timer BH is already disabled.  So this patch
> is redundant.

Yes, I recognized this "after the damage was done".

Thanks and regards,

Jarek P.