Subject: Re: [PATCH] INET: fix incorrect "inet_sock->is_icsk" assignment

From: Paul Moore <[email-masked]>
Date: Mon, 8 Jan 2007 09:47:29 -0500

On Monday, January 8 2007 8:25 am, Jarek Poplawski wrote:
> On 04-01-2007 21:04, Paul Moore wrote:
> > +++ net-2.6.20_bugfix_2/net/ipv4/af_inet.c
> > @@ -305,7 +305,7 @@ lookup_protocol:
> >  		sk->sk_reuse = 1;
> >
> >  	inet = inet_sk(sk);
> > -	inet->is_icsk = INET_PROTOSW_ICSK & answer_flags;
> > +	inet->is_icsk = (INET_PROTOSW_ICSK & answer_flags) ==
> > INET_PROTOSW_ICSK;
>
> Isn't this more readable like this?:
>
> inet->is_icsk = (INET_PROTOSW_ICSK & answer_flags) != 0;

I guess it all depends on who is reading it ;)  Personally, I don't care too 
much either way as long as it is fixed.

-- 
paul moore
linux security @ hp