Subject: Re: [PATCH 3/3] chelsio: more rx speedup

From: Ingo Oeser <[email-masked]>
Date: Wed, 10 Jan 2007 09:30:12 +0100

Stephen Hemminger schrieb:
> On Tue, 9 Jan 2007 09:42:03 +0100
> Ingo Oeser <[email-masked]> wrote:
> > Stephen Hemminger schrieb:
> > > --- netdev-2.6.orig/drivers/net/chelsio/sge.c
> > > +++ netdev-2.6/drivers/net/chelsio/sge.c
> > Please use NET_IP_ALIGN here:
> 
> Wrong, NET_IP_ALIGN is intended to deal with platforms where alignment of DMA is more
> important of alignment of structures.  Therefore if data is copied, it should
> always be 2.

Ah! Thanks for clearing this up. These magic numbers always make my head spin
so I tried to come up with sth. useful :-)

If this pattern is present in many drivers, we might have a define or helper for this.

Regards

Ingo Oeser