From: David Miller <davem@davemloft•net>
To: bunk@stusta•de
Cc: randy.dunlap@oracle•com, akpm@osdl•org,
linux-kernel@vger•kernel.org, netfilter@lists•netfilter.org,
netdev@vger•kernel.org, kaber@trash•net
Subject: Re: [2.6 patch] NF_CONNTRACK_H323 must depend on (IPV6 || IPV6=n)
Date: Sun, 28 Jan 2007 16:04:42 -0800 (PST) [thread overview]
Message-ID: <20070128.160442.48527586.davem@davemloft.net> (raw)
In-Reply-To: <20070129000011.GB6017@stusta.de>
From: Adrian Bunk <bunk@stusta•de>
Date: Mon, 29 Jan 2007 01:00:11 +0100
> On Sun, Jan 28, 2007 at 03:53:48PM -0800, David Miller wrote:
> > Adrian is this the correct way to constrain the selection between
> > "n" and "m" in this kind of situation? I thought doing something
> > like "depends on IPV6" is sufficient to achieve that?
>
> "depends on IPV6" would fix the bug - but it would also make
> NF_CONNTRACK_H323 unavailable for all people without IPV6 support in
> their kernel.
Yes, that is an issue.
I guess with some slightly ugly ifdefs we could support the
whole matrix of possibilities. But perhaps that's undesirable
for another reason.
Patrick?
next prev parent reply other threads:[~2007-01-29 0:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070127234928.64d8e437.akpm@osdl.org>
[not found] ` <20070128114148.b8067721.randy.dunlap@oracle.com>
2007-01-28 22:21 ` [2.6 patch] NF_CONNTRACK_H323 must depend on (IPV6 || IPV6=n) Adrian Bunk
2007-01-28 23:53 ` David Miller
2007-01-29 0:00 ` Adrian Bunk
2007-01-29 0:04 ` David Miller [this message]
2007-01-29 0:21 ` Adrian Bunk
2007-01-29 1:22 ` Randy Dunlap
2007-01-30 17:13 ` Patrick McHardy
2007-01-28 22:31 ` 2.6.20-rc6-mm1 Michal Piotrowski
2007-01-28 23:10 ` 2.6.20-rc6-mm1 Andrew Morton
2007-01-29 5:17 ` 2.6.20-rc6-mm1 Herbert Xu
2007-01-29 5:29 ` 2.6.20-rc6-mm1 Herbert Xu
2007-01-29 6:43 ` 2.6.20-rc6-mm1 Andrew Morton
2007-01-29 7:21 ` 2.6.20-rc6-mm1 Herbert Xu
2007-01-29 8:35 ` 2.6.20-rc6-mm1 Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070128.160442.48527586.davem@davemloft.net \
--to=davem@davemloft$(echo .)net \
--cc=akpm@osdl$(echo .)org \
--cc=bunk@stusta$(echo .)de \
--cc=kaber@trash$(echo .)net \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netfilter@lists$(echo .)netfilter.org \
--cc=randy.dunlap@oracle$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox