From: "John W. Linville" <linville@tuxdriver•com>
To: Larry Finger <Larry.Finger@lwfinger•net>
Cc: Michael Buesch <mb@bu3sch•de>,
netdev@vger•kernel.org, Bcm43xx-dev@lists•berlios.de
Subject: Re: [PATCH] ieee80211: Fix sparse warning
Date: Fri, 2 Feb 2007 15:32:01 -0500 [thread overview]
Message-ID: <20070202203201.GB9382@tuxdriver.com> (raw)
In-Reply-To: <45c1394b.An8WeE68tSLsbJYy%Larry.Finger@lwfinger.net>
On Wed, Jan 31, 2007 at 06:50:19PM -0600, Larry Finger wrote:
> Sparse issues the warning "warning: symbol 'crypt' shadows an earlier one"
> in net/ieee80211/ieee80211_tx.c.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger•net>
> ---
>
> Index: wireless-2.6/net/ieee80211/ieee80211_tx.c
> ===================================================================
> --- wireless-2.6.orig/net/ieee80211/ieee80211_tx.c
> +++ wireless-2.6/net/ieee80211/ieee80211_tx.c
> @@ -502,8 +502,6 @@ int ieee80211_xmit(struct sk_buff *skb,
> if (host_encrypt)
> ieee80211_encrypt_fragment(ieee, skb_frag, hdr_len);
> else if (host_build_iv) {
> - struct ieee80211_crypt_data *crypt;
> -
> crypt = ieee->crypt[ieee->tx_keyidx];
> atomic_inc(&crypt->refcnt);
> if (crypt->ops->build_iv)
Couldn't you remove the "crypt = ieee->crypt[ieee->tx_keyidx];"
as well?
John
--
John W. Linville
linville@tuxdriver•com
next prev parent reply other threads:[~2007-02-02 21:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-01 0:50 [PATCH] ieee80211: Fix sparse warning Larry Finger
2007-02-02 20:32 ` John W. Linville [this message]
2007-02-02 21:38 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070202203201.GB9382@tuxdriver.com \
--to=linville@tuxdriver$(echo .)com \
--cc=Bcm43xx-dev@lists$(echo .)berlios.de \
--cc=Larry.Finger@lwfinger$(echo .)net \
--cc=mb@bu3sch$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox