Subject: Re: [PATCH 3/4] skge: WOL support

From: Ingo Oeser <[email-masked]>
Date: Mon, 5 Feb 2007 14:25:41 +0100

Hi Stephen,

just a nitpick.

Stephen Hemminger schrieb:
> --- skge.orig/drivers/net/skge.c
> +++ skge/drivers/net/skge.c
> @@ -132,18 +132,93 @@ static void skge_get_regs(struct net_dev
>  }
>  
>  /* Wake on Lan only supported on Yukon chips with rev 1 or above */
> -static int wol_supported(const struct skge_hw *hw)
> +static u32 wol_supported(const struct skge_hw *hw)
>  {
> -	return !((hw->chip_id == CHIP_ID_GENESIS ||
> -		  (hw->chip_id == CHIP_ID_YUKON && hw->chip_rev == 0)));
> +	if (hw->chip_id == CHIP_ID_YUKON && hw->chip_rev != 0)
> +		return WAKE_MAGIC | WAKE_PHY;
> +	else
> +		return 0;
> +}

You can delete that comment, if you write exactly, what the comment says:

	if (hw->chip_id == CHIP_ID_YUKON && hw->chip_rev >= 1)
		return WAKE_MAGIC | WAKE_PHY;
	else
		return 0;

Regards

Ingo Oeser