Subject: Re: [RFC: -mm patch] drivers/net/atl1/: possible cleanups

From: Adrian Bunk <[email-masked]>
Date: Wed, 7 Feb 2007 01:24:05 +0100

On Tue, Feb 06, 2007 at 06:19:10PM -0600, Jay Cliburn wrote:
> On Tue, 6 Feb 2007 23:12:29 +0100
> Adrian Bunk <[email-masked]> wrote:
>...
> > This patch contains the following possible cleanups:
> > - move extern declarations to atl1.h
> > - make needlessly global code static
> 
> Adrian,
> 
> The atl1 driver currently follows this development pathway:
> 
> developer -> netdev#atl1 -> netdev#ALL -> -mm
> 
> Your patch is just a little bit out ahead of us.  Some of your suggested
> changes are already in the pipeline; we're just waiting for Jeff to
> merge netdev#atl1 into netdev#ALL.  Should be soon.
> 
> > 
> > Signed-off-by: Adrian Bunk <[email-masked]>
> > 
> > ---
> > 
> > BTW: Can we get a MAINTAINERS entry for this driver?
> 
> Already submitted to netdev#atl1.
> 
> http://lkml.org/lkml/2007/2/3/174

:-)

> > -s32 atl1_setup_ring_resources(struct atl1_adapter *adapter);
> > -void atl1_free_ring_resources(struct atl1_adapter *adapter);
> > +
> > +extern char atl1_driver_name[];
> > +extern char atl1_driver_version[];
> 
> netdev#atl1 already has this change.
> 
> The rest of these I'll bundle up and submit to netdev#atl1, too.  Will
> that work for you?
>...

Do what you consider the right thing - I don't care how it gets into the 
various trees.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed