Subject: Re: [PATCH 1/2][TCP] YeAH-TCP: algorithm implementation

From: Stephen Hemminger <[email-masked]>
Date: Thu, 22 Feb 2007 11:36:36 -0800

Minor comments:

1. Please move  div64_64 out of yeah-tcp (and cubic where you copied it).
   to asm-generic/div64.h

2. Don't need separate tcp_yeah.h just put it in tcp_yeah.c. Also, maybe
   the vegas stuff you copied should go in one place? tcp/vegas.h?

3. whitespace:
	don't do:
		x+=someexpression
		... = max( x, ...
	instead:
		x += someexpression
		... = max(x, ...
	Using indent script in scripts/Lindent will fix these.

4. See if you can replace uses of min_t and max_t with min and max by having
   proper matching types on args. Basically if you need to cast maybe original
   type was wrong.