Subject: Re: s390 allmodconfig

From: Andrew Morton <[email-masked]>
Date: Fri, 2 Mar 2007 03:06:46 -0800

On Fri, 02 Mar 2007 11:38:24 +0100 Johannes Berg <[email-masked]> wrote:

> On Fri, 2007-03-02 at 00:25 -0800, Andrew Morton wrote:
> 
> > Probably related to the Kconfig problems.
> 
> Yeah, it is. s390 is funny, it doesn't include drivers/Kconfig, I don't
> think anybody of us would have suspected that.
> 
> There doesn't seem to be a reason why it shouldn't have drivers/leds
> though. drivers/ssb I don't know about, does s390 have pci or pcmcia?

No, s390 doesn't have PCI.

> And the bluetooth stuff is also plain weird, I suppose s390 really
> should include drivers/hid/Kconfig :)
> 
> Same with drivers/char that includes hw_random.
> 
> Is there any reason it isn't including drivers/Kconfig? 
> 

s390 is weird ;)   There's no way it'll support any of the hardware which you're
working on (until they release the s390 laptop).  So all we really want to
do here is to avoid breaking s390 allmodconfig.
 
> I can offer below patch to fix the LED trigger problem, it's probably
> cleaner to depend on LEDS_TRIGGERS rather than selecting it and
> NEW_LEDS.
> 
> johannes
> 
> --- wireless-dev.orig/net/mac80211/Kconfig	2007-03-02 11:18:45.464333268 +0100
> +++ wireless-dev/net/mac80211/Kconfig	2007-03-02 11:33:24.534333268 +0100
> @@ -13,9 +13,7 @@ config MAC80211
>  
>  config MAC80211_LEDS
>  	bool "Enable LED triggers"
> -	depends on MAC80211
> -	select NEW_LEDS
> -	select LEDS_TRIGGERS
> +	depends on MAC80211 && LEDS_TRIGGERS
>  	---help---
>  	This option enables a few LED triggers for different
>  	packet receive/transmit events.

OK, I'll try that, thanks.