Subject: Re: [PATCH 1/7] NetXen: Use multiple PCI functions

From: Stephen Hemminger <[email-masked]>
Date: Thu, 19 Apr 2007 08:00:59 -0700

On Thu, 19 Apr 2007 07:52:24 -0700
Linsys Contractor Mithlesh Thukral <[email-masked]> wrote:

> NetXen: Make driver use multiple PCI functions.
> This patch will make NetXen driver work with multiple PCI functions. This will
> make the usage of memory resources as well as interrupts more independent
> among different functions which results in better throughput. This change has
> been done after the multiport support is added in firmware.
> 
> Signed-off by: Mithlesh Thukral <[email-masked]>
> 
> ---
> 
>  drivers/net/netxen/netxen_nic.h          |  126 ++---
>  drivers/net/netxen/netxen_nic_ethtool.c  |   83 +--
>  drivers/net/netxen/netxen_nic_hdr.h      |    8 
>  drivers/net/netxen/netxen_nic_hw.c       |  217 ++++++--
>  drivers/net/netxen/netxen_nic_hw.h       |   18 
>  drivers/net/netxen/netxen_nic_init.c     |  117 +---
>  drivers/net/netxen/netxen_nic_isr.c      |   87 +--
>  drivers/net/netxen/netxen_nic_main.c     |  526 ++++++++++-----------
>  drivers/net/netxen/netxen_nic_niu.c      |   27 -
>  drivers/net/netxen/netxen_nic_phan_reg.h |  125 ----
>  10 files changed, 645 insertions(+), 689 deletions(-)
> 
> diff --git a/drivers/net/netxen/netxen_nic.h b/drivers/net/netxen/netxen_nic.h
> index dd8ce35..7a5a95e 100644
> --- a/drivers/net/netxen/netxen_nic.h
> +++ b/drivers/net/netxen/netxen_nic.h
> @@ -219,6 +219,7 @@ #define MIN_RX_COUNT	4096
>  #define NETXEN_CTX_SIGNATURE	0xdee0
>  #define NETXEN_RCV_PRODUCER(ringid)	(ringid)
>  #define MAX_FRAME_SIZE	0x10000	/* 64K MAX size for LSO */
> +#define MAC_ADDR_LEN 	6
>

Please use ETH_ALEN for this if it is an ethernet device.