Subject: Re: [RFC] RF Kill

From: Andrew Morton <[email-masked]>
Date: Thu, 26 Apr 2007 01:00:29 -0700

On Thu, 26 Apr 2007 00:54:57 -0700 (PDT) David Miller <[email-masked]> wrote:

> From: David Miller <[email-masked]>
> Date: Thu, 26 Apr 2007 00:49:51 -0700 (PDT)
> 
> > From: Dmitry Torokhov <[email-masked]>
> > Date: Tue, 10 Apr 2007 02:29:31 -0400
> > 
> > > On Tuesday 10 April 2007 01:58, Dmitry Torokhov wrote:
> > > > Hi,
> > > > 
> > > > This is a modified version of rfkill patch that provides infrastructure
> > > > for controlling state of RF transmitters found on various cards.
> > > 
> > > Well, Andrew found bunch of issues with the patch so here is an
> > > updated version...
> > 
> > Patch applied, although one part of the locking is slightly
> > suspect:
> 
> Actually, I'm reverting this, sorry.
> 
> Besides the locking and other issues I pointed out, this
> thing won't even link.  Please do not test the build with
> various configurations when submitting new code like this.
> 
> Thanks.
> 
>   MODPOST 139 modules
> WARNING: "input_register_handle" [net/rfkill/rfkill-input.ko] undefined!
> WARNING: "input_unregister_handle" [net/rfkill/rfkill-input.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2

ah, OK, it has input dependencies, sorry.  It happens very rarely.