Subject: Re: [patch 04/13] ppp_generic: fix lockdep warning

From: Jarek Poplawski <[email-masked]>
Date: Mon, 14 May 2007 12:09:07 +0200

On Mon, May 14, 2007 at 02:18:31AM -0700, David Miller wrote:
> From: Jarek Poplawski <[email-masked]>
> Date: Mon, 14 May 2007 09:28:45 +0200
> 
> > Yes, this is very good idea, and I wonder, why you didn't try
> > this yourself (after my "ignore").
> 
> Because you are a skilled programmer and you might find some
> flaw in my suggestion :-)
> 

Yes, here are some flaws:

if (Dave_M_was_ignored)
	goto not_skilled_programmer;

if (Jarek_P_finds_some_flow)
	goto message_sent;
else
	goto message_sent; /* probably the same */

Cheers,
Jarek P.