Subject: Re: kernel oops after unloading nf_conntrack_netbios_ns_module

From: Andrew Morton <[email-masked]>
Date: Mon, 14 May 2007 15:14:34 -0700

On Mon, 14 May 2007 09:16:11 +0200
Gabor Burjan <[email-masked]> wrote:

> On Sat, May 12, 2007 at 05:05:51PM +0200, Patrick McHardy wrote:
> > Gabor Burjan wrote:
> > > EIP is at destroy_conntrack+0x52/0x127 [nf_conntrack]
> > >
> > >>>nmblookup <existing_netbios_name>
> > >>>cat /proc/net/ip_conntrack
> > >>>
> > >>>sleep 3
> > >>>
> > >>>rmmod nf_conntrack_netbios_ns
> > 
> > Thanks for the report and good testcase, the crash can only happen with
> > a sleep of >= 3s after the last nmblookup packet was sent.
> > 
> > Can you try if this patch fixes it please?
> 
> Yes, it fixes the problem.

Just speaking generally, rather than about this particualr patch...

Gabor did quite an amount of valuable work here: tested a 2.6.20.x kernel,
developed a test case for reproducing the bug, reported it all quite
exhaustively, tested the resulting patch.

The least we can do in return is to put a big fat "thanks" in the changelog
when the fix gets merged.

> Thank you,

No - thank _you_.