From: Andrew Morton <akpm@linux-foundation•org>
To: "Mariusz Koz__owski" <m.kozlowski@tuxland•pl>
Cc: Jeff Garzik <jeff@garzik•org>,
Linus Torvalds <torvalds@linux-foundation•org>,
netdev@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>
Subject: Re: [git patches] net driver updates
Date: Fri, 18 May 2007 14:54:25 -0700 [thread overview]
Message-ID: <20070518145425.369cb9ff.akpm@linux-foundation.org> (raw)
In-Reply-To: <200705182346.21835.m.kozlowski@tuxland.pl>
On Fri, 18 May 2007 23:46:21 +0200
Mariusz Koz__owski <m.kozlowski@tuxland•pl> wrote:
> Hello,
>
> > diff --git a/drivers/net/smc91x.h b/drivers/net/smc91x.h
> > index 7053026..111f23d 100644
> > --- a/drivers/net/smc91x.h
> > +++ b/drivers/net/smc91x.h
> > @@ -279,6 +279,40 @@ SMC_outw(u16 val, void __iomem *ioaddr, int reg)
>
> ...
>
> > +#define SMC_outb(v, a, r) __ __ __outw(((inw((a)+((r)&~1))*(0xff<<8*(r%2)))) | ((v)<<(8*(r&2)))), (a) + ((r)&~1))
>
> This one has unbalanced parenthesis.
>
I dunno how you can tell - I can't count that high.
Can this be programmed in C, rather than in cpp?
next prev parent reply other threads:[~2007-05-18 21:56 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-08 6:33 [git patches] net driver updates Jeff Garzik
2007-05-18 21:46 ` Mariusz Kozłowski
2007-05-18 21:54 ` Andrew Morton [this message]
2007-05-18 22:16 ` Mariusz Kozlowski
2007-05-18 22:19 ` Gene Heskett
-- strict thread matches above, loose matches on Subject: below --
2008-10-27 23:18 Jeff Garzik
2008-10-28 18:10 ` David Miller
2008-08-14 9:32 Jeff Garzik
2008-08-14 21:54 ` David Miller
2008-08-07 8:50 Jeff Garzik
2008-08-07 9:19 ` David Miller
2008-08-07 10:09 ` Martin Michlmayr
2008-07-30 21:41 Jeff Garzik
2008-07-30 22:49 ` David Miller
2008-05-06 16:42 Jeff Garzik
2008-05-08 9:49 ` David Miller
2008-04-25 7:26 Jeff Garzik
2008-04-25 7:32 ` David Miller
2008-04-26 22:07 ` Ben Hutchings
2008-04-27 0:43 ` David Miller
2008-04-27 2:53 ` Jeff Garzik
2008-04-27 11:34 ` Ben Hutchings
2008-03-29 2:24 Jeff Garzik
2008-03-29 3:02 ` David Miller
2008-02-11 17:05 Jeff Garzik
2008-02-11 20:07 ` Divy Le Ray
2008-02-20 20:38 ` Jeff Garzik
2008-02-21 1:16 ` Divy Le Ray
2008-02-21 3:43 ` Krishna Kumar2
2008-02-21 5:46 ` David Miller
2008-02-21 5:57 ` Divy Le Ray
2008-02-21 6:02 ` Krishna Kumar2
2008-02-21 6:15 ` David Miller
2008-02-21 6:54 ` Divy Le Ray
2008-02-25 22:59 ` Jeff Garzik
[not found] ` <200802260134.02075.mitov@issp.bas.bg>
2008-02-25 23:36 ` Jeff Garzik
2008-02-26 0:13 ` Divy Le Ray
2008-02-26 0:17 ` Jeff Garzik
2008-02-12 5:57 ` David Miller
2008-02-12 12:38 ` Ben Dooks
2008-02-12 16:01 ` Jeff Garzik
2008-02-06 11:49 Jeff Garzik
2008-02-06 11:52 ` David Miller
[not found] <20080122110231.GA18441@havoc.gtf.org>
2008-01-22 14:20 ` David Miller
2007-10-25 7:49 Jeff Garzik
2007-10-24 1:30 Jeff Garzik
2007-10-15 20:19 Jeff Garzik
2007-10-10 1:03 Jeff Garzik
2007-10-10 1:12 ` David Miller
2007-10-05 18:20 Jeff Garzik
2007-10-08 6:06 ` David Miller
2007-10-03 18:39 Jeff Garzik
2007-10-03 22:33 ` David Miller
2007-10-02 17:41 Jeff Garzik
2007-10-02 23:38 ` David Miller
2007-09-29 6:08 Jeff Garzik
2007-09-20 7:26 Jeff Garzik
2007-09-20 18:42 ` David Miller
2007-07-24 20:55 Jeff Garzik
2007-07-18 23:53 Jeff Garzik
2007-07-16 22:57 Jeff Garzik
2007-07-17 8:02 ` maximilian attems
2007-07-10 18:39 Jeff Garzik
2007-07-11 9:34 ` Jiri Kosina
2007-07-11 16:28 ` Chris Stromsoe
2007-05-11 21:58 Jeff Garzik
2007-04-29 16:19 Jeff Garzik
2007-04-29 16:21 ` Christoph Hellwig
2007-02-21 11:46 Roger While
2007-02-21 12:01 ` Johannes Berg
[not found] ` <6.1.1.1.2.20070221124144.04783fb8-Q0ErXNX1RuZq5LbY+mFP1w@public.gmane.org>
2007-02-21 13:27 ` John W. Linville
2007-02-22 15:48 ` Dan Williams
2007-02-20 18:16 Jeff Garzik
2007-02-17 22:17 Jeff Garzik
2007-02-08 0:29 Jeff Garzik
2006-12-11 15:45 Jeff Garzik
2006-12-07 12:14 Jeff Garzik
2006-09-24 16:24 Jeff Garzik
2006-07-05 18:18 Jeff Garzik
2006-06-27 3:57 Jeff Garzik
2006-05-20 4:28 Jeff Garzik
2006-05-20 16:20 ` Andrew Morton
2006-05-20 17:36 ` Linus Torvalds
2006-05-20 17:55 ` Andrew Morton
2006-05-20 22:15 ` Andi Kleen
2006-05-21 7:11 ` Manfred Spraul
2006-05-21 13:24 ` Andreas Kleen
2006-05-21 14:56 ` Manfred Spraul
2006-05-22 12:46 ` Andi Kleen
2006-03-29 23:00 Jeff Garzik
2006-03-24 17:19 Jeff Garzik
2006-03-23 1:34 Jeff Garzik
2006-03-21 21:55 Jeff Garzik
2006-03-20 11:17 Jeff Garzik
2005-09-05 22:47 Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070518145425.369cb9ff.akpm@linux-foundation.org \
--to=akpm@linux-foundation$(echo .)org \
--cc=jeff@garzik$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=m.kozlowski@tuxland$(echo .)pl \
--cc=netdev@vger$(echo .)kernel.org \
--cc=torvalds@linux-foundation$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox