From: Auke Kok <auke-jan.h.kok@intel•com>
To: herbert@gondor•apana.org.au, cebbert@redhat•com
Cc: netdev@vger•kernel.org, jesse.brandeburg@intel•com,
auke-jan.h.kok@intel•com
Subject: [PATCH] e1000: Don't enable polling in open() (was: e1000: assertion hit in e1000_clean(), kernel 2.6.21.1)
Date: Mon, 21 May 2007 08:32:41 -0700 [thread overview]
Message-ID: <20070521153240.5535.31658.stgit@localhost.localdomain> (raw)
Herbert Xy wrote:
"netif_poll_enable can only be called if you've previously called
netif_poll_disable. Otherwise a poll might already be in action
and you may get a crash like this."
Removing the call to netif_poll_enable in e1000_open should fix this issue,
the only other call to netif_poll_enable is in e1000_up() which is only
reached after a device reset or resume.
Signed-off-by: Auke Kok <auke-jan.h.kok@intel•com>
Cc: Herbert Xu <herbert@gondor•apana.org.au>
---
drivers/net/e1000/e1000_main.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c
index 49be393..cbc7feb 100644
--- a/drivers/net/e1000/e1000_main.c
+++ b/drivers/net/e1000/e1000_main.c
@@ -1431,10 +1431,6 @@ e1000_open(struct net_device *netdev)
/* From here on the code is the same as e1000_up() */
clear_bit(__E1000_DOWN, &adapter->flags);
-#ifdef CONFIG_E1000_NAPI
- netif_poll_enable(netdev);
-#endif
-
e1000_irq_enable(adapter);
/* fire a link status change interrupt to start the watchdog */
next reply other threads:[~2007-05-21 15:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-21 15:32 Auke Kok [this message]
2007-05-21 21:26 ` [PATCH] e1000: Don't enable polling in open() (was: e1000: assertion hit in e1000_clean(), kernel 2.6.21.1) Herbert Xu
-- strict thread matches above, loose matches on Subject: below --
2007-05-21 21:51 Auke Kok
2007-05-21 22:16 ` Dave Jones
2007-05-22 0:49 ` Herbert Xu
2007-05-22 0:58 ` Kok, Auke
2007-05-22 1:22 ` Dave Jones
2007-05-21 23:42 ` Jeff Garzik
2007-05-22 0:04 ` Kok, Auke
2007-05-22 1:01 ` Herbert Xu
2007-05-22 16:56 ` Chuck Ebbert
2007-05-22 17:02 ` Kok, Auke
2007-05-23 10:47 ` Herbert Xu
2007-05-23 23:34 ` Chris Wright
2007-05-23 23:38 ` Kok, Auke
2007-05-24 1:29 ` Herbert Xu
2007-05-24 4:31 ` Chris Wright
2007-05-24 1:29 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070521153240.5535.31658.stgit@localhost.localdomain \
--to=auke-jan.h.kok@intel$(echo .)com \
--cc=cebbert@redhat$(echo .)com \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox