Subject: Re: [PATCH 2/2] [IPV6] MIP6: Loadable module support for MIPv6.

From: Ingo Oeser <[email-masked]>
Date: Thu, 24 May 2007 10:36:08 +0200

Masahide NAKAMURA schrieb:
> Ingo Oeser wrote:
> > What about  MODULE_ALIAS("xfrm-type-10-60") 
> > and MODULE_ALIAS("xfrm-type-10-43") in mip6.c ?

Just replace your second patch ("Loadable module support")
with one, which additionally adds these two lines to mip6.c ...

> > The aliases in modprobe.conf(5) should not be necessary then.
> > 
> > If you are really ambitious you can even define a 
> > MODULE_ALIAS_XFRM_TYPE macro in include/net/xfrm.h
> > simliar to to MODULE_ALIAS_XFRM_MODE.
> 
> I prefer to use new macro like XFRM mode to unify XFRM
> protocols i.e. esp[46].c, ah[46].c, ipcomp[46].c, and mip6.c
> if we care about it. Can I add it as extensional patch
> if nobody has a plan to do this yet?

... and provide a third patch to implement this cleanup.

That way there are no administrative changes required due to 
any of your patches and we can defer the global cleanup, if it causes
problems or conflicts with other patches in that area.

Does this sound like a plan?

Regards

Ingo Oeser