public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash•net>
To: netdev@vger•kernel.org
Cc: Patrick McHardy <kaber@trash•net>, hadi@cyberus•ca
Subject: [RFC NET_SCHED 00/02]: Flexible SFQ flow classification
Date: Wed, 30 May 2007 11:40:55 +0200 (MEST)	[thread overview]
Message-ID: <20070530094020.24073.84277.sendpatchset@localhost.localdomain> (raw)

One good thing about ESFQ is the more flexible flow classification, but
I don't like the concept of having a set of selectable hash functions
very much.

These patches change SFQ to allow attaching external classifiers and add
a new "flow" classifier that allows to classify flows based on an arbitary
combination of pre-defined keys. Its probably not the fastest classifier
when used with multiple keys, but frankly, I don't think speed is very
important in most situations where the current SFQ implementation is used.

It currently does not support perturbation, I didn't want to move this into
the classifier, so I need to think about a way to handle it within SFQ.


Some examples:

# behave identical to internal SFQ hash
tc filter add ... flow baseclass x:1 classes 1024 \
		       keys src,dst,proto-src,proto-dst

# the same, but based on source address/port before NAT
tc filter add ... flow baseclass x:1 classes 1024 \
		       keys nfct-src,dst,nfct-proto-src,proto-dst

# classify based on UID
tc filter add ... flow baseclass x:1 classes 1024 \
		       keys sk-uid


and so on .. check out the iproute help text for the full set of supported
keys.


Comments welcome.


 include/linux/pkt_cls.h |   37 +++
 net/sched/Kconfig       |   11 
 net/sched/Makefile      |    1 
 net/sched/cls_flow.c    |  570 ++++++++++++++++++++++++++++++++++++++++++++++++
 net/sched/sch_sfq.c     |   98 +++++++-
 5 files changed, 713 insertions(+), 4 deletions(-)

Patrick McHardy (2):
      [NET_SCHED]: sch_sfq: add support for external classifiers
      [NET_SCHED]: Add flow classifier

             reply	other threads:[~2007-05-30  9:40 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-30  9:40 Patrick McHardy [this message]
2007-05-30  9:40 ` [RFC NET_SCHED 01/02]: sch_sfq: add support for external classifiers Patrick McHardy
2007-05-30  9:40 ` [RFC NET_SCHED 02/02]: Add flow classifier Patrick McHardy
2007-05-30 11:18 ` [RFC NET_SCHED 00/02]: Flexible SFQ flow classification Andy Furniss
2007-05-30 15:32   ` Patrick McHardy
2007-05-30 16:57     ` Andy Furniss
2007-05-30 14:56 ` jamal
2007-05-30 15:27   ` Patrick McHardy
2007-05-30 16:10     ` jamal
2007-05-30 16:23       ` Patrick McHardy
2007-05-30 16:34         ` jamal
2007-05-30 16:55           ` Patrick McHardy
2007-05-30 17:02             ` jamal
2007-08-09  4:12   ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070530094020.24073.84277.sendpatchset@localhost.localdomain \
    --to=kaber@trash$(echo .)net \
    --cc=hadi@cyberus$(echo .)ca \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox