From: Stephen Hemminger <shemminger@linux-foundation•org>
To: Jeff Garzik <jgarzik@pobox•com>, linux-driver@qlogic•com
Cc: netdev@vger•kernel.org
Subject: [PATCH 1/3] qla3xxx: device doesnt do hardware checksumming.
Date: Wed, 30 May 2007 14:23:17 -0700 [thread overview]
Message-ID: <20070530212512.118483672@linux-foundation.org> (raw)
In-Reply-To: 20070530212316.407169588@linux-foundation.org
[-- Attachment #1: qla-ipv6.patch --]
[-- Type: text/plain, Size: 922 bytes --]
Reading the code for ql_hw_csum_setup(), it is obvious that
this driver is broken for IPV6. The driver sets the NETIF_F_HW_SUM
flag, but the code for checksum setup only deals with IPV4.
Compile tested only, no hardware available.
Signed-off-by: Stephen Hemminger <shemminger@linux-foundation•org>
---
drivers/net/qla3xxx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/net/qla3xxx.c 2007-05-30 14:05:12.000000000 -0700
+++ b/drivers/net/qla3xxx.c 2007-05-30 14:09:25.000000000 -0700
@@ -4044,7 +4044,7 @@ static int __devinit ql3xxx_probe(struct
if (pci_using_dac)
ndev->features |= NETIF_F_HIGHDMA;
if (qdev->device_id == QL3032_DEVICE_ID)
- ndev->features |= (NETIF_F_HW_CSUM | NETIF_F_SG);
+ ndev->features |= NETIF_F_IP_CSUM | NETIF_F_SG;
qdev->mem_map_registers =
ioremap_nocache(pci_resource_start(pdev, 1),
--
Stephen Hemminger <shemminger@linux-foundation•org>
next prev parent reply other threads:[~2007-05-30 21:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-30 21:23 [PATCH 0/3] qla3xxx checksum related patches Stephen Hemminger
2007-05-30 21:23 ` Stephen Hemminger [this message]
2007-06-03 15:46 ` [PATCH 1/3] qla3xxx: device doesnt do hardware checksumming Jeff Garzik
2007-05-30 21:23 ` [PATCH 2/3] qla3xxx: cleanup checksum offload code Stephen Hemminger
2007-06-06 23:23 ` Ron Mercer
2007-06-13 19:43 ` Jeff Garzik
2007-06-13 19:55 ` Ron Mercer
2007-06-13 20:04 ` Jeff Garzik
2007-05-30 21:23 ` [PATCH 3/3] qla3xxx: ethtool ops for controlling checksum Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070530212512.118483672@linux-foundation.org \
--to=shemminger@linux-foundation$(echo .)org \
--cc=jgarzik@pobox$(echo .)com \
--cc=linux-driver@qlogic$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox