Subject: Re: [Cbe-oss-dev] [PATCH 12/15] spidernet: increase the NAPI weight

From: Arnd Bergmann <[email-masked]>
Date: Wed, 13 Jun 2007 22:49:51 +0200

On Wednesday 13 June 2007, Jeff Garzik wrote:
> > +/* We really really want to empty the ring buffer every time,
> > + * so as to avoid the RX ram full bug. So set te napi wieght
> > + * to the ring size.
> > + */
> > +#define SPIDER_NET_NAPI_WEIGHT       SPIDER_NET_RX_DESCRIPTORS_DEFAULT
> 
> I don't see why spider_net should have a different NAPI weight from 
> other drivers
> 

Would it help to do it the other way round, as in

#define SPIDER_NET_RX_DESCRIPTORS_DEFAULT SPIDER_NET_NAPI_WEIGHT

and leave that at 64 instead of 256?

	Arnd <><