Subject: Re: [NET]: gen_estimator: fix locking and timer related bugs [Re: [Bugme-new] [Bug 8668] New: HTB Deadlock]

From: Jarek Poplawski <[email-masked]>
Date: Thu, 28 Jun 2007 11:56:03 +0200

On Thu, Jun 28, 2007 at 08:54:48AM +0200, Jarek Poplawski wrote:
...
> > @@ -215,10 +213,7 @@ void gen_kill_estimator(struct gnet_stats_basic *bstats,
> >  			write_unlock_bh(&est_lock);
> >  
> >  			kfree(est);
> > -			killed++;
> >  		}
> > -		if (killed && elist[idx].list == NULL)
> > -			del_timer(&elist[idx].timer);
> 
> I think this is needed. The old timer could be pending, while
> the gen_new_estimator() is run just after this e.g. in
> gen_replace_estimator().

Sorry! I've forgotten there is mod_timer now, so, it's OK!

Jarek P.