Subject: Re: [PATCH -mm 5/9] netconsole: Introduce dev_status member

From: Joel Becker <[email-masked]>
Date: Wed, 4 Jul 2007 23:39:05 -0700

On Wed, Jul 04, 2007 at 04:38:04PM +0530, Satyam Sharma wrote:
> -	if (!(event == NETDEV_CHANGEADDR || event == NETDEV_CHANGENAME))
> -		goto done;
> +	if (!(event == NETDEV_UP || event == NETDEV_DOWN ||
> +	      event == NETDEV_CHANGEADDR || event == NETDEV_CHANGENAME))
> +	      	goto done;
>
>  	if (nt->np.dev == dev) {
>  		switch (event) {

	It's a small nit, but isn't the large if() just the degenerate
default case of the switch()?  Why have it at all?  

Joel

-- 

Life's Little Instruction Book #396

	"Never give anyone a fruitcake."

Joel Becker
Principal Software Developer
Oracle
E-mail: [email-masked]
Phone: (650) 506-8127